Fix SampleXXXAggregatorFunctionTests.testSimpleWithCranky test
#135261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
przemekwitek
added
:Analytics/EQL
elasticsearchmachine
added
the
Team:Analytics
przemekwitek
added
:Analytics/ES|QL
…witek/elasticsearch into fix_testSimpleWithCranky
przemekwitek
changed the title
SampleXXXAggregatorFunctionTests.testSimpleWithCranky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 instances of
SampleXXXAggregatorFunctionTests.testSimpleWithCrankytest started failing after merging #134140.This PR fixes it by making sure the memory clearing line:
is performed under
finallyblock of the try-with-resources statement.Fixes #134918
Marking
>non-issueas this is a fix for a change (#134140) that has not been released yet.